Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/config: replace viper with custom config loader #564

Merged
merged 3 commits into from
May 17, 2024

Conversation

adambabik
Copy link
Collaborator

@adambabik adambabik commented May 1, 2024

This PR implements a generic config loader. The main purpose is to find all relevant runme.yaml starting from a Markdown file location. The algorithm goes up the directory tree until the project root. The next step is to merge all found runme.yaml configs into a single one that will be used by the execution layer.

@adambabik adambabik force-pushed the adamb/replace-viper branch from fc20cf6 to 4bca199 Compare May 1, 2024 18:33
@adambabik adambabik force-pushed the adamb/replace-viper branch 3 times, most recently from e938d2a to fb67d70 Compare May 14, 2024 18:11
@adambabik adambabik requested a review from sourishkrout May 14, 2024 18:18
@adambabik adambabik marked this pull request as ready for review May 14, 2024 18:21
@sourishkrout sourishkrout force-pushed the adamb/replace-viper branch from fb67d70 to f0e4c41 Compare May 17, 2024 20:15
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@sourishkrout sourishkrout merged commit 3d637c0 into main May 17, 2024
5 checks passed
@sourishkrout sourishkrout deleted the adamb/replace-viper branch May 17, 2024 20:20
Copy link

sonarcloud bot commented May 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants